Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Plugin resolution #2019

Closed
wants to merge 7 commits into from
Closed

✨ Plugin resolution #2019

wants to merge 7 commits into from

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Feb 16, 2021 •
edited
Loading

Improve the plugin resolution algorithm. From a conceptual POV, the --project-version is resolved after the --plugins flag, instead of the other way round.

It also adds the Bundle concept, which is a Plugin that wraps other plugins.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Feb 16, 2021 •
edited
Loading

Holding until #2048 and #2059 are merged as it is dependent.
/hold

From the listed commits, only the last is relevant to this PR. The rest are from the linked PR. This commit has no breaking changes, but the previously linke PRs are breaking.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2021
@Adirio Adirio force-pushed the plugin-resolution branch 5 times, most recently from af21009 to 643333e Compare February 17, 2021 07:59
This was referenced Feb 17, 2021
Closed
Closed
@Adirio
Copy link
Contributor Author

Adirio commented Feb 17, 2021

/cc @camilamacedo86

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2021
@Adirio Adirio force-pushed the plugin-resolution branch 6 times, most recently from 86269f5 to f524209 Compare February 25, 2021 07:14
This was referenced Feb 26, 2021
Closed
Closed
@Adirio Adirio force-pushed the plugin-resolution branch 3 times, most recently from dce37c5 to 63525c2 Compare March 1, 2021 21:48
@Adirio Adirio mentioned this pull request Mar 2, 2021
Closed
@Adirio Adirio force-pushed the plugin-resolution branch 3 times, most recently from 59158ff to ba4cf75 Compare March 2, 2021 23:58
@Adirio Adirio mentioned this pull request Mar 3, 2021
Closed
1 task
@Adirio Adirio mentioned this pull request Mar 3, 2021
Merged
@Adirio Adirio force-pushed the plugin-resolution branch 2 times, most recently from 5dd4c7e to 93d90e7 Compare March 6, 2021 12:09
@camilamacedo86
Copy link
Member

camilamacedo86 commented Mar 7, 2021 •
edited
Loading

This PR does not close #1941 .
See my comment in : https://github.com/kubernetes-sigs/kubebuilder/pull/2060/files#r588914741

So, please could you remove it from the first comment.

@Adirio Adirio force-pushed the plugin-resolution branch 3 times, most recently from 46e516c to bd1eb99 Compare March 9, 2021 14:15
@Adirio
Store abstraction for persisting Config
3f1d1b7 
- Use PreRunE and PostRunE functions to handle configuration file loading and saving
- Use a filesystem provided by the cli to persist the project config and to scaffold files

Signed-off-by: Adrian Orive <[email protected]>
@Adirio
Merge branch 'config-store' into plugin-chaining
4690584
@Adirio
Implement plugin chaining (plugin phase 1.5)
705ef0a 
Declarative plugin created to replace the outdated addon pattern

Signed-off-by: Adrian Orive <[email protected]>
@Adirio
Merge branch 'plugin-chaining' into export-machinery
1ecb633
@Adirio
Export and cleanup scaffolding machinery
46e04f3 
- Export scaffolding machinery
- Reorganize scaffolding machinery that was in model
- Remove experimental pattern code (old plugin system)

Signed-off-by: Adrian Orive <[email protected]>
@Adirio
Merge branch 'export-machinery' into plugin-resolution
1fbb697
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2021
@k8s-ci-robot
Copy link
Contributor

@Adirio: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Adirio
Copy link
Contributor Author

Adirio commented Mar 15, 2021

Closed in favor of #2060

@Adirio Adirio closed this Mar 15, 2021
@Adirio Adirio deleted the plugin-resolution branch March 15, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 left review comments

@estroz estroz Awaiting requested review from estroz

@joelanford joelanford Awaiting requested review from joelanford

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow every command to overwrite project-configured plugins
3 participants
@Adirio @k8s-ci-robot @camilamacedo86